Skip to content

Stream::Send fixes: doc + StreamConstPtr byte-by-byte + missing SSL availableForWrite #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 25, 2021
Merged

Stream::Send fixes: doc + StreamConstPtr byte-by-byte + missing SSL availableForWrite #7935

merged 5 commits into from
Mar 25, 2021

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Mar 23, 2021

Should fix #7928

In the following code

        //if (_byteAddressable)
        //    return _peekPointer < _size ? _buffer[_peekPointer++] : -1;
        return _peekPointer < _size ? pgm_read_byte(&_buffer[_peekPointer++]) : -1;

I wonder if it is worth uncommenting the two first lines, which are valid.

@d-a-v d-a-v mentioned this pull request Mar 23, 2021
Closed
@earlephilhower
Copy link
Collaborator

I wonder if it is worth uncommenting the two first lines, which are valid.

I'd say no. Code size increase and pgm_read_byte is only 4 insns extra, anyway, so performance vs. the virtual call overhead should be nothing.

@d-a-v d-a-v changed the title StreamConstPtr: fix doc + reading flash space byte-by-byte Stream::Send fixes: doc + StreamConstPtr byte-by-byte + missing SSL availableForWrite Mar 25, 2021
earlephilhower
earlephilhower approved these changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-a-v d-a-v merged commit c1118df into esp8266:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does ESP8266WebServer and ESP8266WiFi now require non32xfer to be enabled?
2 participants
@d-a-v @earlephilhower